Add new Custom Rector Rule to Pass true to 3rd parameter of in_array when no value provided#3799
Merged
samsonasik merged 4 commits intocodeigniter4:developfrom Oct 23, 2020
Conversation
…when no value provided
Member
Author
|
All green 🎉 |
paulbalandan
approved these changes
Oct 23, 2020
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
Stricter means less prone to errors. 🥳
Can we have also, maybe in a separate PR, other functions which have a $strict parameter also set to true, like in base64_decode and other functions?
Member
Author
|
@paulbalandan Yes, next, I can create new rule for other functions, or refactor it to accept register new function with expected arg position to be true. |
…filled with strict parameter
samsonasik
commented
Oct 23, 2020
Member
Author
|
latest phpstan release seems cause an error https://github.com/phpstan/phpstan/releases/tag/0.12.51 |
Member
Author
|
I currently ignore new unrelated phpstan error due new release of phpstan |
Member
Author
|
All green 🎉 |
michalsn
approved these changes
Oct 23, 2020
samsonasik
deleted the
add-rector-rule-to-pass-third-parameter-true-to-in-array
branch
Member
Author
|
@paulbalandan @michalsn Thank you for the review. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new Custom Rector Rule to Pass
trueto 3rd parameter ofin_arraywhen no value provided.Checklist: